[Ovirt-devel] [PATCH server] migrations bugfix change incorrect 'drop_column' to 'remove_column'

[Jason Guiditta]

On Tue, 2009-03-10 at 12:40 -0400, Mohammed Morsi wrote:
> ---
>  src/db/migrate/031_add_storage_pool_capacity.rb |    2 +-
>  src/db/migrate/032_add_pool_load.rb             |    2 +-
>  src/db/migrate/034_add_vm_vnc.rb                |    4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/db/migrate/031_add_storage_pool_capacity.rb b/src/db/migrate/031_add_storage_pool_capacity.rb
> index dc8e5d4..aff081f 100644
> --- a/src/db/migrate/031_add_storage_pool_capacity.rb
> +++ b/src/db/migrate/031_add_storage_pool_capacity.rb
> @@ -23,6 +23,6 @@ class AddStoragePoolCapacity < ActiveRecord::Migration
>    end
>  
>    def self.down
> -    drop_column :storage_pools, :capacity
> +    remove_column :storage_pools, :capacity
>    end
>  end
> diff --git a/src/db/migrate/032_add_pool_load.rb b/src/db/migrate/032_add_pool_load.rb
> index fbb1b55..9f969fe 100644
> --- a/src/db/migrate/032_add_pool_load.rb
> +++ b/src/db/migrate/032_add_pool_load.rb
> @@ -23,6 +23,6 @@ class AddPoolLoad < ActiveRecord::Migration
>    end
>  
>    def self.down
> -    drop_column :pools, :load_average
> +    remove_column :pools, :load_average
>    end
>  end
> diff --git a/src/db/migrate/034_add_vm_vnc.rb b/src/db/migrate/034_add_vm_vnc.rb
> index f23e24d..7f3a407 100644
> --- a/src/db/migrate/034_add_vm_vnc.rb
> +++ b/src/db/migrate/034_add_vm_vnc.rb
> @@ -23,8 +23,8 @@ class AddVmVnc < ActiveRecord::Migration
>    end
>  
>    def self.down
> -   drop_column :vms, :forward_vnc
> -   drop_column :vms, :forward_vnc_port
> +   remove_column :vms, :forward_vnc
> +   remove_column :vms, :forward_vnc_port
>    end
>  end
>  

ACK, good catch.