[Ovirt-devel] [PATCH node] Fix log rotation.

[Darryl L. Pierce]

On Wed, Mar 18, 2009 at 03:21:07PM -0400, Perry Myers wrote:
> Darryl L. Pierce wrote:
>> From: Darryl Pierce <dpierce at redhat.com>
>>
>> Removes /var/log/messages from the configuration file. Sets the log
>> rotation to take place every 10 minutes.
>
> Looks ok, two minor things.
>
> Do we explicitly remove cron.daily/logrotate?  Since we're putting this 
> to run every 10 minutes we should remove the default daily job.

Sure thing.

> And then minor whitespace nit below...
>
>> Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
>> ---
>>  Makefile.am                    |    2 +-
>>  logrotate/ovirt-logrotate      |   12 +++---------
>>  logrotate/ovirt-logrotate.conf |    2 +-
>>  ovirt-node.spec.in             |    5 +++--
>>  4 files changed, 8 insertions(+), 13 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index af23ae4..e9ae52c 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -49,7 +49,7 @@ EXTRA_DIST =			\
>>    scripts/ovirt-uninstall-node-stateful	\
>>    kinit/ovirt-kinit		\
>>    logrotate/ovirt-logrotate	\
>> -  logrotate/ovirt-logrotate.conf
>> +  logrotate/ovirt-logrotate.conf 
>
> whitespace error?

Hmmm. I didn't notice that before. Yeah, there's a whitespace on the
end. I'll remove it before I push.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste ná Béarla cliste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090318/ca446802/attachment.sig>