[Ovirt-devel] [PATCH server 1/4] * src/Rakefile: do not require gettext for all tasks, breaks rdoc

Scott Seago sseago at redhat.com
Tue May 5 15:52:10 UTC 2009


David Lutterkort wrote:
> ---
>  src/Rakefile |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/src/Rakefile b/src/Rakefile
> index 74b9d18..eebf798 100644
> --- a/src/Rakefile
> +++ b/src/Rakefile
> @@ -1,3 +1,4 @@
> +# -*- ruby -*-
>  # Add your own tasks in files placed in lib/tasks ending in .rake,
>  # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
>  
> @@ -8,14 +9,18 @@ require 'rake/testtask'
>  require 'rake/rdoctask'
>  
>  require 'tasks/rails'
> -require 'gettext/utils'
> +# Do not require 'gettext/utils' here, it breaks rdoc,
> +# require it in tasks that actually need it instead
> +
>  desc "Create mo-files for L10n" 
>  task :makemo do
> + require 'gettext/utils'
>   GetText.create_mofiles(true, "po", "locale")
>  end
>  
>  desc "Update pot/po files to match new version." 
>  task :updatepo do
> + require 'gettext/utils'
>   MY_APP_TEXT_DOMAIN = "ovirt" 
>   MY_APP_VERSION     = "ovirt 0.0.1" 
>   GetText.update_pofiles(MY_APP_TEXT_DOMAIN,
>   
Looks fine, but I'm not sure how to run rdoc in our current setup.
'rake rdoc' didn't find a matching task.

So preliminary ACK once you let me know how to test it :-)

Scott




More information about the ovirt-devel mailing list