[Ovirt-devel] [PATCH node 2/6] add LVM filter support in initrd

[Mike Burns]

On Thu, Oct 01, 2009 at 09:58:39PM -0400, Joey Boggs wrote:
>
>> diff --git a/scripts/ovirt-config-boot b/scripts/ovirt-config-boot
>> index 2961f76..7c5943b 100755
>> --- a/scripts/ovirt-config-boot
>> +++ b/scripts/ovirt-config-boot
>> @@ -108,6 +108,19 @@ ovirt_boot_setup() {
>>          init_script=sbin/real-init
>>      fi
>>      sed -i '/^\/sbin\/udev.*trigger/ a \
>> +filter=\
>> +for o in `cat /proc/cmdline` ; do\
>> +    case $o in\
>> +    filter=*)\
>> +        filter=${o#filter=}\
>> +        ;;\
>> +    esac\
>> +done\
>> +if [ -n "$filter" ]; then\
>> +  mkdir -p /etc/lvm\
>> +  echo "devices { filter = [ \\\"a|^$filter|\\\", \\\"r|.*|\\\" ] }" > /etc/lvm/lvm.conf\
>> +fi\
>> +
>>   
> This extra empty line ^^ causes the install to hang for me on local  
> disk. Take it out and it installs fine.  I'm hitting another issue where  
> the rebuilt initrd causes the boot to hang like we've seen before right  
> after starting udev. Been a long night, so I'll keep working on it in  
> the morning. Have you ran into similar issues during testing?
>
>

I'll fix this, but I'm going to pull back and do some more testing on the complete set.  I didn't see these issues, but I haven't used local disks since the first couple versions of the patch set.  Once I saw it work on local disk, I switched to multipath disks.  I never went back to test local disk again after the final revisions.  

Mike