[Patternfly] Request for working Card View filter

Leslie Hinson lhinson at redhat.com
Mon Jan 9 14:56:28 UTC 2017


Yes, I've updated the bug [1]. We will look to pull this in next sprint.

Dan: Will the core fix need to be merged before fixing the angular version?
Or can this work happen simultaneously?

- Leslie

On Mon, Jan 9, 2017 at 9:48 AM, Matt Carrano <mcarrano at redhat.com> wrote:

> Should we change this (both implementations) to not case sensitive by
> default?
>
> On Mon, Jan 9, 2017 at 9:41 AM, Dan Labrecque <dlabrecq at redhat.com> wrote:
>
>> I simply mimicked the functionality of the Angular toolbar filter.
>> However, app developers can easily change it using the "caseInsensitive"
>> property on the DataTable itself.
>>
>> Dan
>>
>>
>> On 1/9/17 8:41 AM, Leslie Hinson wrote:
>>
>> Dan: I know why I was having issues now... I just realized that the
>> filter is case sensitive. I was typing "gecko" under "Rendering Engine" and
>> was getting 0 results. Therefore I thought the filter was broken. I just
>> tested "Gecko" and realized it does return results. Do we really want
>> filtering to be case sensitive? I wouldn't think so.
>>
>> Leslie
>>
>> On Sun, Jan 8, 2017 at 4:35 PM, Dan Labrecque <dlabrecq at redhat.com>
>> wrote:
>>
>>> FYI, with either example, you must hit enter to apply the filter.
>>>
>>>
>>> On 1/7/17 9:02 AM, Leslie Hinson wrote:
>>>
>>> That's correct, the full implementation is just on the table view for
>>> Core PatternFly. You can check out the angular implementation here:
>>> http://angular-patternfly.rhcloud.com/#/api/patternfly
>>> .filters.directive:pfFilter
>>>
>>> Looks like there is bug on the table view (core) and the filter is not
>>> working as it should. I've filed a bug for this and we will look at this
>>> next sprint. https://patternfly.atlassian.net/browse/PTNFLY-2084
>>>
>>> - Leslie
>>>
>>>
>>> On Thu, Jan 5, 2017 at 10:57 AM, Michal Petrov <mpetrov at redhat.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> for what it's worth I've started adapting the filter for other pages (
>>>> https://rawgit.com/michpetrov/patternfly/pfFilter-dist/dist
>>>> /tests/card-view-multi-select.html) but there's not much to showcase
>>>> with the current data set. (So far the the filter only works for the card
>>>> title)
>>>>
>>>> On Thu, Jan 5, 2017 at 2:29 PM, Andres Galante <agalante at redhat.com>
>>>> wrote:
>>>>
>>>>> Hi Kathryn,
>>>>>
>>>>> Are you using angular patternfly?
>>>>>
>>>>> On Wed, Jan 4, 2017 at 10:52 PM, Kathryn Gough <kgough at redhat.com>
>>>>> wrote:
>>>>>
>>>>>> Greetings
>>>>>>
>>>>>> I'm a UX designer for the RH Certification team and we have been
>>>>>> looking at using some Patternfly components in our designs.
>>>>>>
>>>>>> I have a small request. Both the card and table views in the example
>>>>>> have a filter, but only the table view one works.
>>>>>> - Card view filter (http://localhost:9000/card-view-multi-select.html
>>>>>> )
>>>>>> - Table filter (http://localhost:9000/basic.html)
>>>>>>
>>>>>> Am I missing something to get it working or does the functionality
>>>>>> only work in the table view?
>>>>>>
>>>>>> If a working filter could be implemented into the card view it would
>>>>>> be greatly appreciated.
>>>>>> Does this seem like something the Patternfly team would be willing to
>>>>>> do?
>>>>>>
>>>>>> Kindest regards
>>>>>>
>>>>>> Kathryn
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Patternfly mailing list
>>>>>> Patternfly at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/patternfly
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Patternfly mailing list
>>>>> Patternfly at redhat.com
>>>>> https://www.redhat.com/mailman/listinfo/patternfly
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> Patternfly mailing list
>>>> Patternfly at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/patternfly
>>>>
>>>>
>>>
>>>
>>> _______________________________________________
>>> Patternfly mailing listPatternfly at redhat.comhttps://www.redhat.com/mailman/listinfo/patternfly
>>>
>>> _______________________________________________ Patternfly mailing list
>>> Patternfly at redhat.com https://www.redhat.com/mailman/listinfo/patternfly
>>
>>
>> _______________________________________________
>> Patternfly mailing list
>> Patternfly at redhat.com
>> https://www.redhat.com/mailman/listinfo/patternfly
>>
>>
>
>
> --
> Matt Carrano
> Sr. Interaction Designer
> Red Hat, Inc.
> mcarrano at redhat.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/patternfly/attachments/20170109/773f59d7/attachment.htm>


More information about the PatternFly mailing list