[Pki-devel] [PATCH] 0022-TreeSet

Ade Lee alee at redhat.com
Wed Dec 7 18:34:07 UTC 2011


The change we discussed on #dogtag-pki should be included.  

Specifically, 
<ayoung> alee, this works
<ayoung>      @SuppressWarnings("unchecked")
<ayoung>                             Vector<String> newProfileList =  (Vector<String>) profileList.clone();
<ayoung>                             mProfileList = newProfileList;

Other than that, the patch looks good.

Ade
On Wed, 2011-12-07 at 11:46 -0500, Adam Young wrote:
> On 12/06/2011 10:19 PM, Adam Young wrote: 
> > On 12/06/2011 10:17 PM, Adam Young wrote: 
> > > On 12/06/2011 10:10 PM, Adam Young wrote: 
> > > > On 12/05/2011 08:24 PM, Adam Young wrote: 
> > > > > More type safety cleanup. 
> > > > > 
> > > > > 
> > > > > _______________________________________________
> > > > > Pki-devel mailing list
> > > > > Pki-devel at redhat.com
> > > > > https://www.redhat.com/mailman/listinfo/pki-devel
> > > > 
> > > > There was some concern that replacing the clone method with a
> > > > nother form of type safe copy would have performance
> > > > implications.  This version replaces the clone.
> > > > 
> > > > 
> > > > _______________________________________________
> > > > Pki-devel mailing list
> > > > Pki-devel at redhat.com
> > > > https://www.redhat.com/mailman/listinfo/pki-devel
> > > Missed a couple changes in the last commit.
> > > 
> > > 
> > > _______________________________________________
> > > Pki-devel mailing list
> > > Pki-devel at redhat.com
> > > https://www.redhat.com/mailman/listinfo/pki-devel
> > And missed an @SupressError in it as well. as left in a stray paren.
> > 
> > 
> > _______________________________________________
> > Pki-devel mailing list
> > Pki-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/pki-devel
> New version replaces some of the @Supress with catch blocks
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel





More information about the Pki-devel mailing list