[Pki-devel] [PATCH] 0015-Removal-of-unused-private-methods

Ade Lee alee at redhat.com
Wed Nov 16 14:48:25 UTC 2011


I'm struggling with the premise behind this patch.  Some of these
methods seem like they are valuable - and certainly they were valuable
at some point in time (or they would not have been written).  On the
other hand, I see the benefit of trimming the code base.  No need to
refactor code that isn't being used.

I realize that this removes some eclipse warnings, but is removing these
methods good practice?

I guess I'm looking for some other folks to chime in here.

Ade

On Thu, 2011-11-10 at 22:29 -0500, Adam Young wrote:
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel





More information about the Pki-devel mailing list