[Pki-devel] [PATCH] Fixes review comments on Patch Fixes for Coverity Issues in categories : CALL_SUPER, UNCONFIRMEDCAST, DEAD_STORE, TOSTRING_ARRAY

[Ade Lee]

Pushed to master (patches 7 and 8)

Ade

On Wed, 2012-05-30 at 15:09 -0400, Abhishek Koneru wrote:
> Please find attached the patch which contains fixes for review comments
> given. 
> Smoke Test Passes.
> 
> Regards,
> Abhishek Koneru
> 
> On Tue, 2012-05-29 at 11:44 -0400, Ade Lee wrote:
> > Comments:
> > 
> > 1. The fix in Resender.java is not correct - that is
> > replyRequestId.toString() is not the same as
> > replymsg.reqId.substring(index + 1).  There are some conversions that
> > take place.
> > 
> > I'm OK with reverting your fix here, and marking the bug as
> > intentional/ignore.
> > 
> > 2. In SelfTestSubsystem.java, remove the comments as well:
> >         // strip preceding/trailing whitespace
> >         // from passed-in String parameters
> > 
> > 3. In CMCRevoke, no need to specify : String asciiBASE64Blob = null;
> >    You can just specify String asciiBASE64Blob;
> > 
> > 4. In Request.java, you can specify StringBuffer s = con.getPage();
> > 
> > 5. In PKCS7.java, you need the new byte[] data = byte[len] in case
> > dis.available() == 0 .  I'm not sure I like the way this method is
> > written.  Lets revert the fix and leave this unfixed for now.
> > 
> > 6. Can you explain to me why you think adding the Override tags will fix
> > the call_super issues?
> > 
> > Ade
> > 
> > 
> > On Fri, 2012-05-25 at 14:27 -0400, Abhishek Koneru wrote:
> > > Please find attached the patch with fixes for some of the coverity
> > > issues for review.
> > > 
> > > Thanks & Regards,
> > > Abhishek
> > > _______________________________________________
> > > Pki-devel mailing list
> > > Pki-devel at redhat.com
> > > https://www.redhat.com/mailman/listinfo/pki-devel
> > 
> > 
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel