[Pki-devel] [PATCH] 35 Added option to build without Javadoc.

[Matthew Harmsen]

On 03/23/12 12:53, Endi Sukma Dewata wrote:
> The build scripts have been modified to provide an option to build
> without Javadoc to speed up development builds. The option can be
> used as follows:
>
>   compose_pki_core_packages --without-javadoc hybrid_rpms
>
> Ticket #111
>
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
CONDITIONAL ACK with CAVEATS:

The following invocations succeeded building the RPMS without building 
the javadoc RPMS (it should have failed with a Usage message):

  * pki/scripts/compose_pki_core_packages *--w* hybrid_rpms
  * pki/scripts/compose_pki_core_packages *--without* hybrid_rpms  (note
    that '*--without*' was used instead of '*--without-javadoc*')

while the following invocations failed as expected and issued a Usage 
message:

  * pki/scripts/compose_pki_core_packages *--foo* hybrid_rpms
  * pki/scripts/compose_pki_core_packages *--without-foo* hybrid_rpms
  * pki/scripts/compose_pki_core_packages *--without-javadocs*
    hybrid_rpms (note that '*--without-javadocs*' (plural) was used
    instead of '*--without-javadoc*')

*Please feel free to check-in this patch once this issue has been 
corrected.*

Although I think that it is un-necessary to change code nor necessarily 
document this, the '*--without-javadoc*' option is /*ONLY*/ useful for 
building the '*pki-core*' component (no other '*compose*' scripts 
generate any 'javadoc' packages, and certain packages such as 'pki-tps' 
will NEVER generate javadocs as this is a non-java component).

Additionally, this option would only be utilized when building 'RPMS' 
(e. g. - 'rpms', 'hybrid_rpms', and/or 'patched_rpms'; it is completely 
ignored when building 'srpm', 'hybrid_srpm', and/or 'patched_srpm') 
regardless of component.  However, I don't think that invocation 
necessarily needs to fail which building SRPMS.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20120323/51e8425a/attachment.htm>