[Pki-devel] [PATCH] TRAC Ticket #561 - Replace subprocess.call() with subprocess.check_call()

[Endi Sukma Dewata]

On 8/21/2013 4:46 PM, Endi Sukma Dewata wrote:
> Another thing, there are instances where the stderr is redirected to
> stdout using "2>&1", but the command already has
> stderr=subprocess.STDOUT, so the "2>&1" and shell=True can be removed
> from these commands. This happens in pkihelper.py:2713,2789,2904.
>
> The only invocations that need shell=True are probably
> pkiparser.py:162,169 because they are processing shell variables.
>
> Other than that everything works fine. ACK.

Sorry, spoke too soon. Turns out there's a problem deploying 
Tomcat-based TPS. The pkispawn stops because it's asking for a password.

pkispawn    : INFO     ... configuring 
'pki.server.deployment.scriptlets.configuration'
pkispawn    : INFO     ....... modifying 
'/root/.dogtag/pki-tomcat/tps/password.conf'
pkispawn    : INFO     ....... modifying 
'/root/.dogtag/pki-tomcat/tps/pkcs12_password.conf'
pkispawn    : INFO     ....... Security databases 
'/root/.dogtag/pki-tomcat/tps/alias/cert8.db', 
'/root/.dogtag/pki-tomcat/tps/alias/key3.db', and/or 
'/root/.dogtag/pki-tomcat/tps/alias/secmod.db' already exist!
Enter a password which will be used to encrypt your keys.
The password should be at least 8 characters long,
and should contain at least one non-alphabetic character.

Enter new password:

I'm not sure which line that causes this, but probably the command is 
missing a parameter so it's asking for the password interactively.

-- 
Endi S. Dewata