[Pki-devel] [PATCH] 311 Added TPS authenticator service implementation.

Endi Sukma Dewata edewata at redhat.com
Tue Oct 1 23:28:20 UTC 2013


On 9/30/2013 10:04 PM, Ade Lee wrote:
> 1. The usage in authenticator add-cli does not seem to match.  Should
> the <authenticator id> parameter be removed.

Fixed.

> 2. For several cli, should there be a null check before opening the file
> pointed to by input?

It's not needed because it's already checked by Apache Commons CLI when 
parsing the arguments.

> Otherwise, looks good.
>
> ACK

Pushed to master.

-- 
Endi S. Dewata




More information about the Pki-devel mailing list