[Pki-devel] [PATCH] 72-2 Continuous Integration Framework for DOGTAG_10_0_BRANCH - Solutions for tickets #657, 722, 723, 724, 725

Nathan Kinder nkinder at redhat.com
Thu Oct 24 23:46:01 UTC 2013


On 10/24/2013 03:11 PM, Abhishek Koneru wrote:
> On 10/24/2013 09:58 AM, Abhishek Koneru wrote:
>> Please review the patch attached, which provides the basic setup for a CI Testing framework.
>> It is a huge patch. So I have explained the framework and the contents of the patch in another
>> attached file Test_Framework_Notes. Please go through this document to know what was done in the patch.
>> Why is a jar file (pki-tests.jar) being checked into the source tree?
> Talked to Asha about it. The jar file includes all the java functions from the tet tests for creating crmf requests etc. used in the QE tests.
> She is inclined to removing it and using openssl/curl instead. I am not sure if they are currently using it or not.
> Do you mean to remove the jar and create the jar from source when running the tests?
Yes, that would be ideal.  If we have a jar file checked into the tree 
and something is changed in it, the diffs are useless.  We shouldn't 
have binaries in the tree.
>
> Thanks,
> Abhishek
>
>> Thanks,
>> -NGK
>>
>> This patch has to be applied on the DOGTAG_10_0_BRANCH. I will submit a similar patch for the master branch.
>>
>> Thanks,
>> Abhishek
>>
>> ----- Original Message -----
>> From: "Abhishek Koneru" <akoneru at redhat.com>
>> To: "pki-devel" <pki-devel at redhat.com>
>> Sent: Monday, October 7, 2013 8:42:05 PM
>> Subject: [Pki-devel] [PATCH] 72 Continuous Integration Framework - Solutions for tickets #722, 723, 724
>>
>> Please find the patch which adds all the tests to upstream git on 10.0
>> branch. It is present at pki/tests in the code tree.
>>
>> The junit tests source code and the extensions for Suite junit runner
>> and the junit.RunNotifier are present at
>> pki/tests/beaker/rhcs/dev_java_tests/src. The code is compiled to
>> pki/tests/beaker/rhcs/dev_java_tests/bin. (This has been setup in the
>> project). Once the project is opened in eclipse the code is compiled
>> there. Except for the junit4.jar, there are no other requirements for
>> building the java tests in eclipse. Though for making an rpm of all the
>> tests we need the following packages installed:
>>
>> expect, beah, rhts-test-env, beakerlib, beakerlib-redhat, rhts-devel,
>> beaker-client.
>>
>> The presence of these packages also provides all the beaker client
>> functionality.
>>
>> A compose script, compose_pki_test_package, is added to pki/scripts.
>> This script when executed, creates a folder X/package.tests(X=pki/..)
>> and copies all the tests there and builds the rpm. Building a
>> personalized rpm is possible only when the build is made outside the git
>> tree. Executing the make-package.sh script inside at
>> pki/tests/beaker/rhcs is not possible if the tags of the current branch
>> are different from the master. (Similar problem faced in SVN v<1.7).
>> Hence the rpm is build outside the pki source tree.
>>
>>    --- Abhishek
>>
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/pki-devel
>>
>>
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/pki-devel




More information about the Pki-devel mailing list