[Pki-devel] <pki-devel> [PATCH] 0006- Further work on TPS Processor, format operation.patch

[John Magne]

  Ticket #895


Thanks to ACKs from edewata and cfu, pushed to master.


----- Original Message -----
> From: "Endi Sukma Dewata" <edewata at redhat.com>
> To: "John Magne" <jmagne at redhat.com>, "Christina Fu" <cfu at redhat.com>
> Cc: pki-devel at redhat.com
> Sent: Wednesday, March 19, 2014 6:32:15 PM
> Subject: Re: [Pki-devel] <pki-devel> [PATCH] 0006- Further work on TPS Processor, format operation.patch
> 
> Just one more comment, in TPSSession read(), write(), process(), and
> probably some methods in TPSProcessor, we can actually catch the
> IOException, log the message, then throw the original exception object.
> No need to create a new IOException wrapper because we aren't changing
> the exception type.
> 
>    try {
>        ...
>    } catch (IOException e) {
>        CMS.debug(...);
>        throw e;
>    }
> 
> Everything else is good, and the code is a lot easier to read. ACK.
> 
> --
> Endi S. Dewata
>