[Pki-devel] Dogtag 10 Python Profile Client API documentation for review

[Ade Lee]

Some basic comments to be begin with:

1. You do not include methods and parameters for ProfileOutputa and
ProfilePolicySets.

2.  In your initial setup code, you put the auth-cert.pem in /tmp.  Its
better to put that in the user's home directory.  Also, you make a
connection to the http port.  That cannot be correct because all these
calls require client auth.

3.  In your code example in creating an profile, you use the
add_attribute() method to add attributes to an existing inout. It would
also be valuable to add methods to add/remove attributes from
ProfileInput.

so   input = ProfileInput("SubjectNameInput", "com.netscape....")
     input.add_attribute(ProfileAttribute("sn_e"))
     ...
     profile.add_input("id1", input)

4.  In fact, I think your example is not correct.  There is an id --
like "id1" which is associated with the profile, not the specific input.

5.  You need to specify which paramters are optional.  Those that are
optional should be made keyword params with a default.

6.  When deleting a profile, the profile must be disabled first.

Ade
On Wed, 2014-04-30 at 01:00 -0400, Abhishek Koneru wrote:
> Please review the documentation for the ProfileClient on the python side.
> 
> Link: http://pki.fedoraproject.org/wiki/Dogtag_10_Python_Profile_Client_API
> 
> --Abhishek
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel