[publican-list] Use of language-codes in Publican

[Jeff Fearn]

Asgeir Frimannsson wrote:
> ----- "Jeff Fearn" <jfearn at redhat.com> wrote:
> 
>> Asgeir Frimannsson wrote:
>>> ----- "Asgeir Frimannsson" <asgeirf at redhat.com> wrote:
>>>> Hi publicans and others,
>>>>
>>>> I was doing some work earlier today with Fedora release notes and
>>>> publican, and noticed a potential issue with locale names. 
>>>>
>>>> Publican seem to expect locales in the form of $lang-$country,
>> e.g.
>>>> en-US or hi-IN. 
>>>>
>>>> 1) Many open source projects use underscore rather than hyphen for
>>>> locale codes, for example en_US or hi_IN. I'm all in favour of the
>>>> publican-approach, and converting projects to use these is
>> trivial.
>>>> 2) For some languages, a country code in the locale name is not
>> used,
>>>> and this breaks publican when running 'make report-all'. 
>>> Sorry, the target that fails is 'publish-report', where the process
>> spits out a lot of messages like:
>>> "Use of uninitialized value $language in string eq at
>> /usr/bin/StSe_Reports line 72."
>>
>> This is a minor bug in the way this script generates the html reports.
>> Are there any other issues?
>>
>> Does 'make report-total-all' work properly?
> 
> Yes, this seem to work fine. 
> 
> I have no idea of how and what the other targets do, but I see heaps of references in the documentation to '<LANG>-<LOC>' (via make help), and using a code without the '-<LOC>' would IMO not typically produce a predictable result :)
>

I'm not going to change the language about <LANG>-<LOC> since that's the "recommended" way, but it should certainly work just using <LANG>.

I opened this bug: https://bugzilla.redhat.com/show_bug.cgi?id=465201

And closed it :)

I'm pretty sure two character language codes should work correctly now. I've certainly been able to update translations using two character codes, produce HTML, PDF and RPM outputs, and translation reports.

I also reworked the layout of the reports since I thought they looked awful.

You can see the new layout at http://jfearn.fedorapeople.org/Test_Report/

Cheers, Jeff.

-- 
Jeff Fearn <jfearn at redhat.com>
Software Engineer
Engineering Operations
Red Hat, Inc
Freedom ... courage ... Commitment ... ACCOUNTABILITY