[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Pulp-list] Api.update() semantics change



Thanks for looking.

On 02/28/2011 03:36 PM, Jay Dobies wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

One small note, there are now two methods in test_api called
test_repo_update  :)

I think the 2nd one got added last sprint.  I'll consolidate them.


On 02/28/2011 01:15 PM, Jason L Connor wrote:
On Fri, 2011-02-25 at 15:46 -0600, Jeff Ortel wrote:
RepoApi and associated unit tests converted and pushed to master.  All
nosetests are
clean.  Review and feedback appreciated.

Hi Jeff,

The code looks much cleaner now, thank you for taking on this task.

I do have one comment, in the RepoApi constructor are the following
fields:

self.localStoragePath = constants.LOCAL_STORAGE
self.published_path = os.path.join(self.localStoragePath, "published", "repos")
self.distro_path = os.path.join(self.localStoragePath, "published", "ks")

I believe that all of these could live in the constants module. The
first is just a new reference to something already in the constants
module. The second two are read-only constants based on the first, and
should probably live with the rest of the constants. Keeping everything
that's hard-coded in pulp in on place seems desirable from a programming
stand point.




_______________________________________________
Pulp-list mailing list
Pulp-list redhat com
https://www.redhat.com/mailman/listinfo/pulp-list


- --
Jay Dobies
RHCE# 805008743336126
Freenode: jdob
http://pulpproject.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNbBVcAAoJEOMmcTqOSQHCvwAIAIYkdB/Gs+X+Lby4lBR+vGY1
e2V6nxIlagy+3XhpzM9GavZDa7BqrB0+hJ7N1S48uGqAwfroDk4j8hWrvjrn/ZCm
yRrfQoptvRqOSiBZsZZB1l6wkqvIP1l4ajj+nN+OuKFQGZp7U6FwgMpdHFuiaRlV
SoR+z2C0vCAUwH4N2fV/l8K56dWf+X3gRe1buZnuP6ZzqZjub3fTOFivYSySjBi+
kh8HKmRb3wr//C+47B+6vbnoWNN6A5xKz4FrFQt76AUqHM73ItzidokcADQA6j0g
PCp4G2xfGGm1Rsd7nrgj2HAR1wF4VSfDT0kNzzKZeP3XKAK1sKVmuY+wOvuPLmw=
=tYWX
-----END PGP SIGNATURE-----

_______________________________________________
Pulp-list mailing list
Pulp-list redhat com
https://www.redhat.com/mailman/listinfo/pulp-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]