[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Pulp-list] Unit Tests



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I love the fact that we started adding more unit tests. Now we're at the
point where we need to clean them up a bit. The unit tests are taking
upwards of 50 minutes to run.

There are some tests that make calls out over the network. These really
need to have some sort of timeout on them and/or find a way to simulate
those calls locally.

A few people have noted that "test_get_repo_packages_multi_repo" either
takes an especially long time to run or times out entirely. Can someone
take a look at this?

It's not just enough that we're writing unit tests. Test cases are first
class code, not something hacked together just to meet a feature
checklist quota. So please try to be cognizant of what that code is
doing and how it can be optimized.

Please try to take a few minutes next week in the between-sprint limbo
time to think about any tests you may have introduced that either take a
long time to run or have the potential to hang. 45 minutes is way longer
than a project of our size should take to run.

- -- 
Jay Dobies
RHCE# 805008743336126
Freenode: jdob @ #pulp
http://pulpproject.org | http://blog.pulpproject.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJN8mjLAAoJEOMmcTqOSQHCQKMH/0Ivv4E6eHdidcVFB24kBVp+
RsuGLvZg0c6A0joDpJkfyzryhqXyFWQYj+fmnpGNtqliqApulYzWMun6paHkiaEn
Y0WsDkW6r3P4+zS/k6IydubDGvht/krRgyYPx31gGMco0Vm/aRyfVOV8pe7//KxX
pr1s+U1s6WhZ40Ar//iGlTxeMECRxBZQdAfnYP+qgnRksZgzGVzCTM/0YA1n4owf
WDI9XwqM0Hi8RFdhIXrqHfn+43YdyyVhm2cHpabvhPugmH4JlnCbFkqFhomoVNJY
K5b48saX28WgzEf9gJ5ZRhhDLJzVBrPVrCywRPheeIn9c/MHQB4Bn8hgB6ul6hE=
=n8W0
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]