[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Pulp-list] debugging rhel5 pulp unit tests

Hey ..
I'm trying to debug the unit tests on rhel5 and I have a couple observations on what is causing the errors. I first thought the setup on the jenkins slave was messed up, so I reinstalled on a new box. I was however able to recreate the exact issues. The unit tests run w/o error on RHEL6, and I'm not sure if its appropriate to change the unit tests based on the version of rhel its running on.
Anyway.. here's what I've found thus far.

Platform unit test error:

  File "/usr/lib64/python2.4/logging/handlers.py", line 71, in emit
    if self.shouldRollover(record):
File "/usr/lib64/python2.4/logging/handlers.py", line 150, in shouldRollover
    self.stream.seek(0, 2)  #due to non-posix-compliant Windows feature
ValueError: I/O operation on closed file

I'm not sure what is causing the issue, but if you remove the python-paste module (Paste) you won't get the io error, just an import error.. heh

rpm -support unit tests:
These tests were also bailing out w/ an exception on two arguments.. 'retry_delay' and 'num_retries'

TypeError: setup() got an unexpected keyword argument 'num_retries'
TypeError: setup() got an unexpected keyword argument 'retry_delay'

attached is a diff w/ those arguments removed:

diff --git a/rpm-support/plugins/importers/yum_importer/importer.py b/rpm-support/plugins/importers/yum_importer/importer.py
index e7812aa..487f162 100644
--- a/rpm-support/plugins/importers/yum_importer/importer.py
+++ b/rpm-support/plugins/importers/yum_importer/importer.py
@@ -40,7 +40,7 @@ OPTIONAL_CONFIG_KEYS = ['feed_url', 'ssl_verify', 'ssl_ca_cert', 'ssl_client_cer
                         'proxy_url', 'proxy_port', 'proxy_pass', 'proxy_user',
                         'max_speed', 'verify_size', 'verify_checksum', 'num_threads',
                         'newest', 'remove_old', 'num_old_packages', 'purge_orphaned', 'skip', 'checksum_type',
-                        'num_retries', 'retry_delay']
+                        'retry_delay']
 # Config Options Explained
diff --git a/rpm-support/plugins/importers/yum_importer/importer_rpm.py b/rpm-support/plugins/importers/yum_importer/importer_rpm.py
index 665c96c..61af835 100644
--- a/rpm-support/plugins/importers/yum_importer/importer_rpm.py
+++ b/rpm-support/plugins/importers/yum_importer/importer_rpm.py
@@ -438,8 +438,7 @@ class ImporterRPM(object):
         self.yumRepoGrinder = get_yumRepoGrinder(repo.id, repo.working_dir, config)
         set_progress("metadata", {"state": "IN_PROGRESS"})
-            self.yumRepoGrinder.setup(basepath=repo.working_dir, callback=progress_callback,
-                num_retries=num_retries, retry_delay=retry_delay)
+            self.yumRepoGrinder.setup(basepath=repo.working_dir, callback=progress_callback)
         except Exception, e:
             set_progress("metadata", {"state": "FAILED"})
             _LOG.error("Failed to fetch metadata on: %s" % (feed_url))
diff --git a/rpm-support/test/unit/data/test_errata_local_sync/repodata/06c3048a7e3cf369716f11f769810ae592e03852d0b6e799481ee492984552c0-updateinfo.xml b/rpm-support/test/unit/data/test_errata_local_sync/repodata/06c3048a7e3cf369716f11f769810ae592e03852d0b6e799481ee492984552c0-updateinfo.xml
deleted file mode 100644
index 137a909..0000000
--- a/rpm-support/test/unit/data/test_errata_local_sync/repodata/06c3048a7e3cf369716f11f769810ae592e03852d0b6e799481ee492984552c0-updateinfo.xml
+++ /dev/null
@@ -1,24 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-	<update from="enhancements redhat com" status="final" type="enhancements" version="1">
-		<id>RHEA-2010:9999</id>
-		<title>test package enhancements</title>
-		<issued date="2010-11-7 00:00:00"/>
-		<updated date="2010-11-8 00:00:00"/>
-		<description/>
-		<references/>
-		<pkglist>
-			<collection short="F13PTP">
-				<name>F13 Pulp Test Packages</name>
-				<package name="emoticons" version="0.1" release="2" epoch="0" arch="noarch" src="xen-3.0.3-80.el5_3.3.src.rpm">
-					<filename>emoticons-0.1-2.x86_64.rpm</filename>
-					<sum type="sha">663c89b0d29bfd5479d8736b716d50eed9495dbb</sum>
-				</package>
-				<package name="patb" version="0.1" release="2" epoch="0" arch="noarch" src="xen-3.0.3-80.el5_3.3.src.rpm">
-					<filename>patb-0.1-2.x86_64.rpm</filename>
-					<sum type="sha">017c12050a97cf6095892498750c2a39d2bf535e</sum>
-				</package>
-			</collection>
-		</pkglist>
-	</update>

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]