[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Pulp-list] line lengths in pulp



110 sounds like a reasonable limit. PEP-8 says 79, but that's not as strictly followed as nearly everything else in PEP-8.

Michael

----- Original Message -----
From: "Jay Dobies" <jason dobies redhat com>
To: pulp-list redhat com
Sent: Wednesday, February 6, 2013 9:00:24 AM
Subject: Re: [Pulp-list] line lengths in pulp

On 02/05/2013 05:54 PM, Jeff Ortel wrote:
> While reviewing pull requests recently, I saw code with lines lengths
> exceeding the width of the code review pane in github.  This width
> appears to be 110 characters.  Many of these lines were far longer and
> since the scrollbar is at the bottom, this can be very annoying.
>
> Does anyone know if this width can be changed in github?  Making the
> window wider does not seem to help.  If not, I propose a coding
> guideline in pulp that requires lines to be <= 110 characters for this
> reason.

+1

The horizontal scrolling is surprisingly really annoying. I hadn't seen 
a number on github's width, but 110 sounds feasible without imposing 
annoying restrictions on the code.

> _______________________________________________
> Pulp-list mailing list
> Pulp-list redhat com
> https://www.redhat.com/mailman/listinfo/pulp-list


-- 
Jay Dobies
Freenode: jdob @ #pulp
http://pulpproject.org

_______________________________________________
Pulp-list mailing list
Pulp-list redhat com
https://www.redhat.com/mailman/listinfo/pulp-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]