[Pulp-list] Thoughts regarding #214

[Dennis Gregorovic]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 04/28/2015 11:26 AM, Jeff Ortel wrote:
> Team,
> 
> When working on issue #214, I'm finding the following:
> 
> 1. The last_published property on a Distributor document is updated
>    even if the publish fails.
> 
> 2. The last_published is stored as iso8601 string instead of an ISODate.
> 
> To support #214, I think both of these things need to be changed.  The
> last_published needs to be migrated to be an ISODate in the DB.  And,
> the last_published needs to only be updated on success.
> 
> I can maintain API backwards compatibility by serializing the
> last_published property as an iso8601 string.  But, the suggested change
> of only updating it on success would represent a slight change in the
> meaning.  Though, I'd be surprised if it's used for anything other than
> display.
> 
> Questions:
> 
> 1. Would this be acceptable in a Y release or does this need to wait for
> the next major release?
> 
> 2. Would it break anything?
> 
> Thoughts?
> 
> 
> -jeff
> 
> 
> [1] https://pulp.plan.io/issues/214
> 
> _______________________________________________
> Pulp-list mailing list
> Pulp-list at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-list
> 

I wonder if the repo_publish_results collection would be a better data source for this API.  I don't think it existed when the RFE was originally filed.

- -- Dennis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJVP8DCAAoJEC5GQnwcej689P4QAJJUeiZJZ0HSpgUSgtoLDio0
4lc3LQsErrlFzasNhsHG4QvYPEBIvwRvnY/1ASgAIDI52Wr/EHdI/mV98ZkOrJIj
p9QbnH1ilS38qt8X6GK2ePm2uwwCZR8epUDTQ1O2Yt4KFia1luC3T7gIV+AuoH7U
oaqgwuJ976vYRWpLiZmXSZ1DnOfJye+Ts8BFXU9GtAU19jEh/IVVQPpZk05XOi0I
sil0aqgqLar6NveMrX5xjOhZJoVnS+DkoCO8XaQ/G/DyvJ4DLGAO5UuBIp0/vD4X
ckuckZfQWdltwfsUWDqf1dtYWbazVCkdgHKiNLXbTSu6G0aSJWTnuPfHub+BqYhb
wtffqvtH1vhlifRWzmC0wObD75VTBmCnY9O+A4b/qXu0WZZn/nvRVXIhWMfA++bR
h92GvaWcGCKBSp9eUXvFzEH3QHr79yke07OjDNdG7nK7BeS44lC+gGHVBUY4ZdmN
JnfqQ9vVkbzgRQGuC3RABp1GwfDrb4oQKHo7MkZcnowLZxnk8o907xtuZAC9HZhm
oXo0+3rJfBmmEIDjf0ZLx3OAvFT7+G+Vv3Wk8cDS9MqUeJztXf4Zqsu018jwBaxj
JARMxpJrC29Fl7hwoLqW2yLn5PGpr1qYU7pu3dxCWXF+V1AwV1lFgfixlq2d0hM1
bO61MRBGtdc8J4WKjdDu
=bRe0
-----END PGP SIGNATURE-----