[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Pulp-list] [devel] import ordering for pulp code



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/25/2015 10:37 AM, Chris Duryee wrote:
> There is a library that adds import order checking to flake8[1]. Is
> this something we can enable for Pulp platform? This would let us
> look at one less thing during PR review.
> 
> The linter ships with two styles, one written by the authors of
> the module and the other is the Google code style. Examples are at
> [2] and [3]. I'd be OK personally with either style.
> 
> If we wanted to use this linter, we may need to set it up but not 
> include it in run-tests.py until all of the imports are fixed.
> Currently there are about 350 errors.

I'm +1 on the linter idea. The more we can automate PR review, the
more efficiently we can work.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJU7i5NAAoJEIyFaKUJtmpi1JcP/i3e31DPmHcW3J1k3PptoF+r
a4yXPIwQu1En0sqBSsOaKN1Kt9/fkv+O3nENL75BG0J0DLfoZ6vl1LkiD+6/JbCz
NIyrIJnCRnpn+NF/XmuQZQAe7V+29QYkoGb2tx55BdW5nS3/KorfBHF40Q+YW5qb
cjPn3YrRXFj1ElcP28iJ3ooKgo0NZCnMLIFeMsa476pGe4Y73JTdgE+SZIlXJoSQ
LuBp4YSLI9jWngcsL2piShTUfrDjGH9MyyFRfPsYicnkDAp4JED1iF5gMexhfl+B
fdBQFFdvCb2x+gaMgXu04gjuPxztPORTC5IwVsK7VoGaMV8N+70y4o1OP5CFO+6E
Q+ut6uPKdMZmXl4yOH7XBt9oODQaykitYSB/R4uqiC20NsYKNX0sJz7HiRU8+nmW
txgI/Rk5Hn1a/aiu2uBQiPnJwDBCt5Mu/3q13Jb5WKJWEp5NgFKeFefF3gUPWJqq
XX1cvgBtAnRahYfBjqGV55Egg2Z6KvqeB509cjeCkja2kTcUgK0/OaubhjlxtljC
YwdB3OKBevPmU17DUgb512dhcpDJIcgdEtosgcsgwxjcyWnsBXIXM39ZMHqvV6dl
C8OkuORtDQvaUomJIKbgn2Cp8UxhqlsTT6MOBuIJspGYDhxlmipoXBKRs7D9xgOo
28W1mDxn0z++qe7KPfEO
=l61y
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]