rhn-applet patch [was Re: [rhn-users] up2date...]

Daniel Veillard veillard at redhat.com
Fri Mar 19 23:46:22 UTC 2004


On Fri, Mar 19, 2004 at 10:13:40AM -0500, Bob Drzyzgula wrote:
> On Thu, Mar 18, 2004 at 07:31:33PM -0500, Todd Warner wrote:
> > 
> > Patches gladly accepted. Send 'em our way and we'll take a look-see.
> > rhnlib and up2date are GPLed software so... there you go.
> > 
> > Definately sounds like something is funky though. I will make sure the
> > right people know about it.
> > 
> > -- 
> > ____________
> >  /odd Warner                                    <taw@{redhat,pobox}.com>
> >           Bit Twiddler - Operation Cheetah Flip - Red Hat Inc.
> > ---------------------gpg info in the message headers--------------------
> > "But when you think about it, it's mostly the bad decisions we make
> >  that change our lives. Good ones just get you home safely." -Chris Bliss
> 
> rhn-applet patch:
> 
> # This is a patch against RHEL 3.0WS rhn-applet-2.0.12
> #
> # This patch will add support for a configurable http user agent string
> # in the RHN toolbar applet. It relies on parallel patches to rhnlib
> # and up2date. Affected source files are
> #
> #   rhn_applet.py
> #   rhn_applet_model.py
> #   rhn_applet_rpc.py
> #
> # This patch does not enable the user agent string to be configured via the
> # applet's GUI configuration dialog; configuration can only be done in
> # the applet's configuration file, e.g. ~/.rhn-applet.conf
> #
> # This patch is provided as is, with no warranty.
[...]
> @@ -202,7 +204,8 @@
>                                                 self.__cert__,
>                                                 self.__proxy__,
>                                                 self.__proxy_username__,
> -                                               self.__proxy_password__)
> +                                               self.__proxy_password__,
> +                                               self.__user_agent_string__)
>  

  Interesting but this requires first the rhnlib patch to be deployed
unless trying a try:...except: around this call to retry with
one less parameter in case the old API didn't got deployed yet.
Other way is to add a Requires in the spec to the updated rhnlib version.

Daniel

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/





More information about the rhn-users mailing list