[sos-devel] Gluster component update for sos

[Bryn M. Reeves]

On 07/11/12 20:42, Adam Stokes wrote:
> On 11/7/2012 12:39 AM, Amar Tumballi wrote:
>> On 10/23/2012 11:24 PM, Amar Tumballi wrote:
>>> Hi all,
>>>
>>> I am attaching two patches which we are planing to have as part of sos
>>> for RHS2.0 (based on sos-2.2_17.el6_2).
>>>
>>> 0001-* was the first patch, done to perform 'statedump' only on one
>>> machine and to avoid 'gluster volume statedump'/'gluster volume status
>>> *' commands from the gluster component, with which we saw couple of
>>> issues.
>>>
>>> We had couple of comments from Bryn on this patch, and the result is
>>> 0002-* patch which tried to remove the usage of /tmp/* directories. Also
>>> fixed an issue which Bryn saw on RHEL machines (without glusterd
>>> binary).
>>>
>>
>> Guys, any review comments on the patches? would like to get it in.
>>
>> Regards,
>> Amar
>>
>> _______________________________________________
>> Sos-devel mailing list
>> Sos-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/sos-devel
>>
> The easiest way to get these reviewed and pulled in would be to fork the
> project on github and create your pull requests that way. Unfortunately
> I do not have admin priv's to the master repo or I'd take a look at it

To be honest I find it easier to review patches via a mailing list -
github is OK if you like doing things through a browser but it doesn't
make it any easier if you're trying to work from a terminal.

Regards,
Bryn.