[sos-devel] [PATCH] powerpc: Collect more debug files for PowerNV platform

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Mar 11 13:29:47 UTC 2014


On 03/11/2014 05:53 PM, Bryn M. Reeves wrote:
> On 03/11/2014 11:38 AM, Vasant Hegde wrote:
>> On 02/20/2014 07:15 PM, Vasant Hegde wrote:
>>> This patch adds support to collect more debug files on
>>> PowerNV platform.
>>
>> Hi Bryn,
>>
>> Did you get a chance to look into this patch?
>
> Hi Vasant,
>
> Sorry, this one appears to have slipped through. I've pushed it now as
> commit a66d4fc (minor tweaks to the commit message and whitespace).

Bryn,

Commit looks good.. Thanks for making correction..

> Looking at the code we have now in this plugin I see we collect a few
> bits from /proc/ppc64 for pSeries:
>
>          if ispSeries:
>              self.add_copy_spec("/proc/ppc64/lparcfg")
>              self.add_copy_spec("/proc/ppc64/eeh")
>              self.add_copy_spec("/proc/ppc64/systemcfg")
>
> Whereas PowerNV picks up the whole tree:
>
>          if isPowerNV:
>              self.add_copy_spec("/proc/ppc64/")
>
> Is there really nothing of interest in there for pSeries systems or
> should we just pick up the whole tree if it's present?

Its intentional.. On pSeries /proc/ppc64 contains more files than what we need 
for debug.. Also some of those files takes longer time to copy. Hence we added 
only required file..

Whereas in PowerNV /proc/ppc64 contains minimal files which are required .. 
Hence copying everything..

-Vasant



>
> Regards,
> Bryn.
>




More information about the sos-devel mailing list