[sos-devel] [PATCH] [powerpc] Fix files to copy list delimiter

[Kamalesh Babulal]

Currently some elements in files to copy list are missing
delimiter commas. Without delimiters the members are concatenated
into single element and are treated as single file name, which
does not exist :

2015-10-26 00:31:53,465 INFO: [plugin:powerpc] added copyspec '/proc/ppc64/systemcfg/proc/ppc64/topology_updates/sys/firmware/opal/msglog'
and ignoring the file, as it does not exist.

This patch fixes the issue by introducing list elements delimiter,
so the files are treated individually and are captured:

2015-10-26 00:33:23,500 INFO: [plugin:powerpc] added copyspec '/proc/ppc64/eeh'
2015-10-26 00:33:23,500 INFO: [plugin:powerpc] added copyspec '/proc/ppc64/systemcfg'
2015-10-26 00:33:23,500 INFO: [plugin:powerpc] added copyspec '/proc/ppc64/topology_updates'
2015-10-26 00:33:23,500 INFO: [plugin:powerpc] added copyspec '/sys/firmware/opal/msglog'
2015-10-26 00:33:23,501 INFO: [plugin:powerpc] added copyspec '/var/log/opal-elog/'

Reported-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
Bisected-by: Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
Signed-off-by: Kamalesh Babulal <kamalesh at linux.vnet.ibm.com>
Cc: Bryn M. Reeves <bmr at redhat.com>
---
 sos/plugins/powerpc.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sos/plugins/powerpc.py b/sos/plugins/powerpc.py
index 051c237719a7..9252cf2ccf11 100644
--- a/sos/plugins/powerpc.py
+++ b/sos/plugins/powerpc.py
@@ -83,8 +83,8 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin):
         if isPowerNV:
             self.add_copy_spec([
                 "/proc/ppc64/eeh",
-                "/proc/ppc64/systemcfg"
-                "/proc/ppc64/topology_updates"
+                "/proc/ppc64/systemcfg",
+                "/proc/ppc64/topology_updates",
                 "/sys/firmware/opal/msglog",
                 "/var/log/opal-elog/"
             ])
-- 
2.6.0.rc1