[Spacewalk-devel] spacewalk-branding.spec: a7c8f8dd85f28a44e33fdd2ac88e7eb90ed1dcc8

Jesus M. Rodriguez jesusr at redhat.com
Wed Jul 30 16:23:03 EDT 2008


Your recent commit, http://tinyurl.com/6mdc5w , I'd suggest a few changes.

Change the %install to use install instead of mkdir to install. And
remove the rm -rf. For example, instead of this:

  rm -rf %{buildroot}
  mkdir -p %{buildroot}/var/www/html
  cp -R css %{buildroot}/var/www/html/
  cp -R img %{buildroot}/var/www/html/

Do this:
  install -d -m 755 %{buildroot}/%{_var}/www/html
  cp -R css %{buildroot}/%{_var}/www/html/
  cp -R img %{buildroot}/%{_var}/www/html/

I know we're not consistent in other places, but no need
to propagate it.


jesus m. rodriguez     | jesusr at redhat.com
sr. software engineer  | irc: zeus
red hat network        | 919.754.4413 (w)
rhce # 805008586930012 | 919.623.0080 (c)
|  "Those who cannot learn from history     |
|   are doomed to repeat it."               |
|                       -- George Santayana |

More information about the Spacewalk-devel mailing list