[Spacewalk-devel] [PATCH] Added NULL checks in setMaxFlex() and setMaxMembers()

Jan Pazdziora jpazdziora at redhat.com
Thu Jan 27 02:49:07 EST 2011


On Thu, Jan 27, 2011 at 10:07:57AM +0530, Paresh Mutha wrote:
> Hello,
> 
> I am proposing a patch which includes NULL checks for setMaxFlex()
> and setMaxMembers() in ChannelOverview.java.
> 
> Without that, in few cases where maxFlex or maxMembers were null, it
> led to NullPointerException and page https://server.example.com/rhn/admin/multiorg/OrgSoftwareSubscriptions.do?oid=<orgid>
> failed with an ISE.
> 
> We already have a bugzilla created for RHN Satellite v5.4 -
> https://bugzilla.redhat.com/show_bug.cgi?id=671450

Paresh,

did you investigate why (in which situation) does the setMaxFlex
and/or setMaxMembers get called with null? Shouldn't/couldn't we
handle this on the caller's side, rather than in the setter?

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat




More information about the Spacewalk-devel mailing list