[Spacewalk-devel] [PATCH] support for weak dependencies
jpazdziora at redhat.com
Wed Mar 9 06:21:41 EST 2011
On Wed, Mar 09, 2011 at 11:11:08AM +0100, Jan Pazdziora wrote:
> On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote:
> > Hello,
> > attached is a patch set which implement weak rpm dependencies (Recommends,
> > Suggests, Supplements) into spacewalk.
> > This patch set implements: parsing weak dependencies during spacewalk-repo-
> > sync, store them into the database, show them in the WebUI and generate them
> > into new created channel metadata.
> when I apply the patches to Spacewalk nightly and try rhnpush (of
> openSUSE rpm or Spacewalk rpm),
> I get the following traceback:
> File "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", line 186, in _populateTag
> v = sanitizeList(header[rf])
> File "/usr/lib/python2.6/site-packages/spacewalk/common/rhn_rpm.py", line 68, in __getitem__
> return self.hdr[name]
> ValueError: unknown header tag
> Could you please investigate? Do you need list of rpms I have
> installed or something?
One thing which might be good to have when you submit patch sets
with new features / functionality would be examples of commands or
steps (CLI, API, WebUI) which would make it easy to see the feature
in action, or reference to some specs page which would have the
steps. In this case I just tried rhnpush as that was the easiest
for me and I got stuck right at the beginning, which became kinda
blocker for the whole patch set.
But maybe you did not verify the change with rhnpush at all because
it does not fit your workflows and you have some other "preferred"
way to get the feature running and observe it, which would unblock
me in reviewing it.
If you and your peers could add "reproducer steps" to your
submissions in the future, it would be cool. Ideally they should be
fairly specific about what exact rpm file / repository / whatever
was tested and is supposed to work.
Principal Software Engineer, Satellite Engineering, Red Hat
More information about the Spacewalk-devel