[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Spacewalk-devel] [PATCH] Pam setting on the user page not saving



On 10/12/2011 05:22 PM, Johannes Renner wrote:
On 10/12/2011 05:00 PM, Tomas Lestach wrote:
Hello Johannes,

yes, you're right.

I just have one comment to your patch - I'd move updatePamAttribute() in SelfEditAction.java file
into the updateDetails method. If you're ok with the change, I'd commit it.
Let me know.

Yes, I was just keeping things separated, but it seems as if there would be no
difference in the semantics. And you rather mean the class UserEditActionHelper,
right? You will then also need to add another parameter for the updateDetails()
method (the loggedInUser), but sure, commit it ;-)

Yes, that's what I meant. Even if not described very well. :-)
My intention was to use updateDetails() method to set the pam attribute as it is one of the details as well.

commited as: fbadff4927b0ca257cdd29a175507e8cbd600faf
http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=fbadff4927b0ca257cdd29a175507e8cbd600faf

Thank you!
--
Tomas Lestach
RHN Satellite Engineering, Red Hat



Thanks,
Johannes

Regards,
--
Tomas Lestach
RHN Satellite Engineering, Red Hat


On 10/12/2011 02:28 PM, Johannes Renner wrote:
Hello,

I just fixed a bug in Spacewalk about the pam setting on the user page not saving,
it can be reproduced like this:

1. Configure pam on the server (e.g. echo "pam_auth_service = rhn-satellite">>   /etc/rhn/rhn.conf)
2. Restart the tomcat
3. Log into spacewalk as an org_admin
4. In the page header click on<username>   to edit the user's settings
5. Check on/off the "use pam" checkbox
6. Click on update

Result: The pam setting is not saved and the checkbox on the resulting page is
therefore shown in the same state as before.

(Note that it works to set the pam option for a user via "Users" ->   <username>)

Apply my attached patch for a fix, i.e. save the pam option using either
AdminUserEditAction.java or SelfUserEditAction.java.

Thanks,
Johannes

P.S.: I can also create a bugzilla entry if necessary, just tell me.




_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel redhat com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel redhat com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel redhat com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]