[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Spacewalk-devel] [PATCH] Filters on reposync



Hi,

I've just looked at reposync.py code a I don't see any part related to getting include/exclude filters from database as properties of repositories that Jan asked me when i've submited  some code for filters (he said that he didn't like that filters are specified at runtime).

Any news on it ?
If, you decide to store filters in database, these will be accessible through repositories webui ?

Regards.

Baptiste

----- Mail original -----
De: "Baptiste AGASSE" <baptiste agasse lyra-network com>
À: spacewalk-devel redhat com
Envoyé: Mardi 13 Septembre 2011 16:24:22
Objet: Re: [Spacewalk-devel] [PATCH] Filters on reposync

Hi Michael,

> my original idea was to be able to stack includes / excludes on top of
> each other, e.g.
>         include=openoffice.org-*
>         exclude=openoffice.org-draw,openoffice.org-langpack*
>         include=openoffice.org-langpack-en,openoffice.org-langpack-de
> which in the end will sync openoffice.org packages except *-draw and
> *-langpacks but will also include  *langpack-en and *langpack-de.

Ok, i know that my solution don't care about include/exclude order and can't do this, but i can take a look on it

> The filtering and dependecy resolver parts look good. I'm not keen on
> inheriting ContentSource from yum.YumBase because it leads to implicit
> import of all yum repos defined in the server's /etc/yum.repo.d/ which have
> nothing to do with repos defined in Spacewalk (the application). Morever
> you have to delete them so they not mess up with the valid spacewalk
> repos.

Yes, i haven't found many resources on it, i did the best i could to use yum dependency resolver

> % - All versions of the packages excluded by a filter is now deleted
> % from DB and filesystem

> Well, this changes current behavior of spacewalk-repo-sync because we
> never remove packages which are already in the channel during sync
> process. E.g. you might have packages pushed manually (via rhnpush) into
> channel, should they also be removed? I don't think so.
> I decided skip this part of patch for now.

Yes, in the patch that I've submitted, include/exclude is in repository scope: only excluded packages from current repository are deleted

Regards.

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel redhat com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel redhat com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]