[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate



Applied as: https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=f7044a01be5211f00a2acd7b845e36da61357d63
I just removed unused imports.

Thank you!
--
Tomas Lestach
Red Hat Satellite Engineering, Red Hat


----- Original Message -----
> From: "Silvio Moioli" <smoioli suse de>
> To: spacewalk-devel redhat com
> Sent: Tuesday, July 2, 2013 9:33:08 AM
> Subject: Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate
> 
> On 07/01/2013 05:14 PM, Tomas Lestach wrote:
> > All right, so in case the bug does not evince in current Spacewalk,
> > will it
> > be visible when we upgrade to newer hibernate (which version) or
> > any other component?
> 
> As far as I know, patched code is fragile regardless of Hibernate
> version (we encountered the bug with 3.2.4.1). See, as an example,
> the
> following method:
> 
> public static List<Errata> publishToChannel(List<Errata> errataList,
> Channel chan, User user, boolean inheritPackages)
> 
> This will fail if "chan" is not a real instance of ClonedChannel but
> rather a proxy loaded from Hibernate. This is not easily
> reproducible,
> because Hibernate can return either a true ClonedChannel or a proxy
> depending on the type of lookup, state of the cache, object graph,
> etc.
> and indeed, in our case, channel was indirectly loaded from
> ChannelFactory.getAccessibleChildChannels(). Unfortunatelu, despite
> several efforts, I am still not able reproduce a bug with upstream
> Spacewalk code so far.
> 
> Regards,
> --
> Silvio Moioli
> SUSE LINUX Products GmbH
> Maxfeldstraße 5, 90409 Nürnberg Germany
> 
> _______________________________________________
> Spacewalk-devel mailing list
> Spacewalk-devel redhat com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]