[Spacewalk-list] Remove MOTD

[Tomas Lestach]

Hello Mario,

we've reviewed your patch.
We cannot accept your patch, because you've completely removed the MOTD 
feature.

I suggest following behavior:

if /etc/motd has no content, let's put the original MOTD_FOOTER message 
in there to keep the current behavior. Otherwise (when f.e. a 
configuration file was deployed) just do nothing and keep the file content.

If you'll send us a patch with this (or any other agreed) behavior, I'll 
accept the patch.

I CCed the spacewalk-devel list, because that's the preferred list to 
send patches to.
https://fedorahosted.org/spacewalk/wiki/PatchProcess


Regards,
Tomas
--
Tomas Lestach
RHN Satellite Engineering, Red Hat


On 02/17/2011 06:20 PM, Schugowski, Mario wrote:
> Hello,
>
> i have downloaded the complete Spacewalk Sourcecode, and here ist he needed Patch for removing
> the /etc/motd Stuff from the Code. The Patch is against the KickstartFormatter.java in src/com/redhat/rhn/manager/kickstart
>
> --- KickstartFormatter.java.ori	2011-02-17 18:14:43.955738001 +0100
> +++ KickstartFormatter.java	2011-02-17 18:15:00.223737987 +0100
> @@ -79,11 +79,6 @@
>           Config.get().getString("web.product_name") + " Config Management" +
>           NEWLINE;
>       private static final String COMMENT = "#" + NEWLINE;
> -    private static final String MOTD_FOOTER = "# MOTD" + NEWLINE + "echo>>  /etc/motd" +
> -        NEWLINE + "echo \"" + Config.get().getString("web.product_name") +
> -        " kickstart on \\$(date +'%Y-%m-%d')\">>  /etc/motd" +
> -        NEWLINE + "echo>>  /etc/motd" + NEWLINE + NEWLINE +
> -        "# end of generated kickstart file";
>       private static final String BEGINRHN = "%post --logfile " +
>          "/root/ks-rhn-post.log" + NEWLINE +
>          "# --Begin " + Config.get().getString("web.product_name") +
> @@ -266,7 +261,6 @@
>           buf.append(NEWLINE);
>           addCobblerSnippet(buf, "post_install_kernel_options");
>           addCobblerSnippet(buf, "koan_environment");
> -        buf.append(MOTD_FOOTER);
>           buf.append(NEWLINE);
>           buf.append("$kickstart_done");
>           buf.append(NEWLINE);
>
> will it be possible, that the patch will be applied to the next Packages ? I will open tomorrow
> again a Ticket in the Red Hat Ticket System for that. 4 Years ago i had an Ticket for this Problem without
> any patch.
>
> Thank you !
>
> Bye Mario
>
>
>
> -----------------------------------
> Computacenter AG&  Co. oHG, mit Sitz in Kerpen (Amtsgericht Köln HRA 18096)
> Vertretungsberechtigte Gesellschafter:
> Computacenter Aktiengesellschaft, mit Sitz in Köln (Amtsgericht Köln HRB 28384)
> Vorstand: Oliver Tuszik (Vorsitzender), Dr. Karsten Freihube, Hans-Georg Freitag, Frank Kottmann, Reiner Louis
> Aufsichtsrat: Michael Norris (Vorsitzender)
> Computacenter Management GmbH, mit Sitz in Köln (Amtsgericht Köln HRB 28284)
> Geschäftsführer: Ulrich Irnich
> Visit us on the Internet: http://www.computacenter.de
> Visit our Online-Shop: https://shop.computacenter.de
>
> This email is confidential. If you are not the intended recipient, you must not disclose or use the information contained in it. If you have received this mail in error, please tell us immediately by return email and delete the document.
> -----------------------------------
>
>
> _______________________________________________
> Spacewalk-list mailing list
> Spacewalk-list at redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-list