[Spacewalk-list] [BULK] Re: Incorrect timezone in new 2.1 date / time picker.

[Alan Pittman]

Just an FYI (for anyone that cares) -
   "There's only one other GMT-0500 timezone choice available (Indiana), where they don't observe DST" - actually, yes they do. They (the state of Indiana) adopted DST in 2005 and implemented it in 2006.

Alan

From: spacewalk-list-bounces at redhat.com [mailto:spacewalk-list-bounces at redhat.com] On Behalf Of Duncan Mac-Vicar P.
Sent: Friday, March 28, 2014 12:17 PM
To: Ron Helzer
Cc: spacewalk-list at redhat.com; spacewalk-devel
Subject: [BULK] Re: [Spacewalk-list] Incorrect timezone in new 2.1 date / time picker.
Importance: Low

On 28/03/14 17:05, Ron Helzer wrote:
There's only one other GMT-0500 timezone choice available (Indiana), where they don't observe DST... That, in conjunction with the fact that there were no DST issues pre-2.1, would suggest to me that the GMT-0500 (Eastern) setting should account for EDT/EST change.

Are you suggesting I'm supposed to change the preference twice a year to manually account for DST?

No, I am just trying to understand where the issue can come from, as I don't think anything changed at all.

In 2.0 the date picker fragment got the timezone from the DatePicker bean (picker.calendar.timeZone)
https://github.com/spacewalkproject/spacewalk/blob/SPACEWALK-2.0/java/code/webapp/WEB-INF/pages/common/fragments/date-picker.jsp (line 60)

In 2.1, the JSP tag gets the timezone from the DatePicker bean in the same way
https://github.com/spacewalkproject/spacewalk/blob/SPACEWALK-2.1/java/code/src/com/redhat/rhn/frontend/taglibs/DateTimePickerTag.java (line 225)

Then the time passed to the server on submit does not carry the timezone, so it is always relative to the one it was shown to you.
(I am not saying there is not a problem, but I can't see how it would be new if there is).

CCing -devel in case anyone sees something I am missing.


--

Duncan Mac-Vicar P. - http://www.suse.com/



SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)

Maxfeldstraße 5, 90409 Nürnberg, Germany


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/spacewalk-list/attachments/20140328/b1d85057/attachment.htm>