[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] utrace_add_engine() should set ->utrace_flags |= REAP



> Before 04852f35ff95f2a48cf8c38faf365b7d61f4370a we had invariant:
> ->utrace_flags != 0 if and only if we have attached engines, now
> we don't because utrace_add_engine() does not set REAP.

I think that was an accidental deletion.
I can't see any reason I would have done it.

> I believe this invariant is very nice, and it is better to keep it.

I agree completely.


Thanks,
Roland


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]