[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCHWORK] [virt-manager] fullscreen behaviour



On 11/22/2009 01:18 PM, Cole Robinson wrote:
> On 11/21/2009 02:35 PM, Jon Nordby wrote:
>>
>> On Thu, Nov 19, 2009 at 6:02 PM, Cole Robinson <crobinso redhat com
>> <mailto:crobinso redhat com>> wrote:
>>
>>     Yep, everything appears exactly as you described. Maybe we can stick 
>>
>>     Â with the current method, but try to find a way to hide the
>>     hide/unhide 
>>
>>     the menu if we switch away from the details window, using window signals
>>     or something. This could be risky because if we had some unexpected
>>      false positive or bug, the menu might not unhide. 
>>
>>     Â 
>>
>>     Also, this behavior reveals a small bug: we should probably kick off the
>>     menu hide timer when mouse leaves the menu, not when it enters the VNC
>>     widget. Otherwise if you switch workspaces while the mouse is over the
>>     Â menu, it won't hide without switching back to virt-manager.
>>
>>
>> The problem is that a drop down menu spawns a new window, so you will
>> get a "leave" event on the menubar when the user opens a menu. This is
>> why I did not connect the menu hide timer there. It also complicates
>> your proposition of hiding the entire window using similar signals.
>> Unless there is a good and reliable way to find out if the user is
>> interacting with a drop down menu...
> 
> Ahh interesting, didn't realize.
> 
>> In any case, I don't expect to have time to look at this for the next
>> couple of weeks. Just so you know.
>>
>> Btw: have you given any thought to when you want to get virt-manager 0.9
>> out? Or what you want done before then.
> 
> I'm hoping to cut virt-manager 0.8.1 this week (probably wednesday, before US
> thanksgiving). I'd really like to include this patch, so I'll poke at it a bit
> to try and fix the workspace switching problem.
> 

I took a stab at this before the release, but didn't have much luck fixing the
known sticky issue. My original thought of trying hiding the menu bar is a bit
scary anyways: if we get it wrong, the user could end up in the VNC window
with no menu bar, which would be pretty terrible if they don't know how to get
out.

I think the long term way forward would be to port the AutoView widget used by
vinagre to python: it looks like it has only gtk dependencies so should be
pretty straight forward, just a good amount of work. I'm still not opposed to
your patch in the interim if we can fix the issues.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]