[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] [virt-manager] multiple graphs in manager window



On 11/10/2009 02:14 PM, Jon Nordby wrote:
> Attaching and inlining. What is the preferred way?

Attached is fine, inlining tends to mangle long lines with many clients.

> Network graphing did not work here, but seems unrelated to this patch.
> 

Hmm, everything seems wired up correctly here (since at least the test
driver works, which fakes network/disk activity).

Patch looks great though, I've applied now with one minor change.

>              "on_vm_manager_delete_event": self.close,
>              "on_menu_file_add_connection_activate": self.new_connection,
> @@ -845,11 +848,15 @@
>          nameCol.set_expand(True)
>          nameCol.set_spacing(6)
>          cpuUsageCol = gtk.TreeViewColumn(_("CPU usage"))
> -        cpuUsageCol.set_min_width(150)
> +#         cpuUsageCol.set_min_width(150)
> +        diskIOCol = gtk.TreeViewColumn(_("Disk I/O"))
> +        networkTrafficCol = gtk.TreeViewColumn(_("Network I/O"))
> 

I reenabled this set_min_width, dropped it to 140, and applied it to all
the stats columns. That way they all have the same spacing and keep the
size ratio used by the current CPU graph.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]