[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] VMM - Show host device information bits



On 10/26/2009 12:29 PM, Michal Novotny wrote:
> On 10/26/2009 05:20 PM, Cole Robinson wrote:
>> On 10/26/2009 10:59 AM, Michal Novotny wrote:
>>    
>>> Hi,
>>> this is new version of host device information bits, tested with PCI
>>> devices as well.
>>>
>>> Thanks,
>>> Michal
>>>
>>>      
>> I think we should support USB devices by bus/addr and PCI devices before
>> pushing.
>>
>>    
> Well, I didn't find it in devs (get_devices()) so that I can't check how 
> to compare it using bus/addr. I've been using testdriver.xml you wrote 
> about but get_devices() returns empty list and I can't make PCI 
> passthrough working right on my machine.

Make sure you pull down the updated testdriver, and are using libvirt
0.7.2. You should see results from get_devices.

>> The libvirt test driver now supports host device routines as of 0.7.2,
>> so if you pull that version and install, you should be able to use my
>> updated test driver to emulate PCI and USB device passthrough:
>>
>> http://fedorapeople.org/~crobinso/virt-manager/testdriver.xml
>>
>> Another thing, after looking at the UI changes, we are exposing a lot of
>> redundant info. If the device info lookup succeeds, we should just set
>> 'Source Device' to use dev.pretty_name(), which gives all the info they
>> might want. This saves us having to add a bunch of UI fields that may
>> not be populated anyways.
>>
>>    
> What data would you like to limit it to? Source Device should be 
> dev.pretty_name() and what about other information? I have tested it on 
> WinXP virtual machine with Bluetooth device passed to the VM and all the 
> fields were populated. I am attaching a screenshot of my WinXP VM with 
> Bluetooth device assigned...
> 

I would like to limit it to pretty_name only for now, since pretty name
contains both the product and device name, so listing them separately is
redundant.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]