[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 5 of 5] viewer: add support for spice resize-guest



Hi!

On Thu, Dec 9, 2010 at 12:20 PM, Daniel P. Berrange <berrange redhat com> wrote:
> Could you explain a little more why SPICE doesn't want to be
> inside an alignment widget. In VNC we use that to ensure that
> you get either vertical or horizontal black bars if the window
> is resized to a non-guest native aspect ratio. How does spice
> deal with resizing & scaling & aspect ratios ?

spice-gtk doesn't need alignment widget. It already draws black
borders. Gerd originally wrote the code this way. I don't know why,
but it works. If we have enough reason to change this behaviour, I am
ok dropping that code.

Regarding resizing, spice will resize the guest desktop to fit in the
the client window.

I discussed with the team about adding scaling functionality as well,
to match with gtk-vnc behavior, but they all seemed to tell me it was
non-sense, since it can just resize the desktop instead. I still find
that scaling could be useful in some 'weird' cases, but I don't think
we can combine both behaviors. Thus, I prefer to keep guest desktop
resizing.

regards

-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]