[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 5 of 6] console: support SPICE



On 12/17/2010 08:51 AM, Marc-André Lureau wrote:
> # HG changeset patch
> # User Marc-André Lureau <marcandre lureau redhat com>
> # Date 1291221765 -3600
> # Node ID 36976fe992df8ebdbe52fca392feb6a284ae3e1c
> # Parent  01667175a00b22b91f3592761dbd148a5bb47d58
> console: support SPICE
> 

It might be a good idea to have separate commits for some of the
mechanical changes, like s/vncViewer/viewer/, pulling the Tunnel object
out, etc.

Also, if the spice widget isn't installed, we should show an appropriate
console error. Right now, virt-manager will fail entirely trying to
import the module.


>  
>  gobject.type_register(vmmConsolePages)
> diff -r 01667175a00b -r 36976fe992df src/virtManager/create.py
> --- a/src/virtManager/create.py	Fri Dec 17 14:33:35 2010 +0100
> +++ b/src/virtManager/create.py	Wed Dec 01 17:42:45 2010 +0100
> @@ -1118,7 +1118,7 @@
>          # Set up graphics device
>          try:
>              guest._graphics_dev = virtinst.VirtualGraphics(
> -                                        type=virtinst.VirtualGraphics.TYPE_VNC,
> +                                        type=virtinst.VirtualGraphics.TYPE_SPICE,
>                                          conn=guest.conn)
>              guest.add_device(virtinst.VirtualVideoDevice(conn=guest.conn))
>          except Exception, e:


This should be a separate patch, and even then I don't know if it should
be an unconditional default change (maybe dependent on OS type/QXL
support or similar). I have to educate myself a bit more here.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]