[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 5 of 6] console: support SPICE



Hi

On Mon, Dec 20, 2010 at 7:10 PM, Cole Robinson <crobinso redhat com> wrote:
> On 12/17/2010 08:51 AM, Marc-André Lureau wrote:
> Also, if the spice widget isn't installed, we should show an appropriate
> console error. Right now, virt-manager will fail entirely trying to
> import the module.

Shouldn't it be required? Just like gtkvnc?

>> diff -r 01667175a00b -r 36976fe992df src/virtManager/create.py
>> --- a/src/virtManager/create.py       Fri Dec 17 14:33:35 2010 +0100
>> +++ b/src/virtManager/create.py       Wed Dec 01 17:42:45 2010 +0100
>> @@ -1118,7 +1118,7 @@
>>          # Set up graphics device
>>          try:
>>              guest._graphics_dev = virtinst.VirtualGraphics(
>> -                                        type=virtinst.VirtualGraphics.TYPE_VNC,
>> +                                        type=virtinst.VirtualGraphics.TYPE_SPICE,
>>                                          conn=guest.conn)
>>              guest.add_device(virtinst.VirtualVideoDevice(conn=guest.conn))
>>          except Exception, e:
>
>
> This should be a separate patch, and even then I don't know if it should
> be an unconditional default change (maybe dependent on OS type/QXL
> support or similar). I have to educate myself a bit more here.

If qemu supports Spice, there shouldn't be any drawback. I'll leave
that change out for now, but it should be considered when we make
Spice the default.

(Thanks for your comments, I am sending a rebased version of the patches)

regards

-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]