[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 5 of 6] console: support SPICE



On 12/22/2010 04:36 AM, Marc-André Lureau wrote:
> Hi
> 
> On Mon, Dec 20, 2010 at 7:10 PM, Cole Robinson <crobinso redhat com> wrote:
>> On 12/17/2010 08:51 AM, Marc-André Lureau wrote:
>> Also, if the spice widget isn't installed, we should show an appropriate
>> console error. Right now, virt-manager will fail entirely trying to
>> import the module.
> 
> Shouldn't it be required? Just like gtkvnc?
> 

Actually I don't think gtkvnc should be strictly required either and I'd take
a patch to make it optional. Granted distros should certainly use rpm/deb/etc.
to require gtkvnc and gtkspice, but this way it will make life easier for
users pulling from upstream, and distros that haven't packaged gtkspice yet
(like F14 and RHEL6, which will likely get the next virt-manager version)

The change can come as an additive patch though.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]