[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [fedora-virt] ANNOUNCE: New releases virt-manager 0.8.3 and virtinst 0.500.2



On 02/09/2010 10:25 AM, Cole Robinson wrote:
I'm happy to announce two new releases:

virt-manager 0.8.3: virt-manager is a desktop application for managing
KVM and Xen virtual machines via libvirt.

Note that this new virt-manager exposes a memory leak in the augeas library (used by the netcf library, which libvirt uses for the host interface config APIs). After several hours of an open host connection in virt-manager, libvirt's memory footprint grows to several hundred MB.

The cause of the leak has been found, and a patch submitted, but if anyone wants to avoid this leak in the interim, you can get the augeas source from:

  git clone git://git.fedorahosted.org/git/augeas.git

and apply the attached patch.
--- Begin Message ---
From: Laine Stump <laine laine org>

Found with valgrind + lutter.

The result of pathjoin() was used only as an argument to tree_find(),
but wasn't being freed before return. Over the course of 12 hours or
so running the latest virt-manager, this racked up a few hundred MB of
leaked memory.

A shorter (but still valid) test of 1/2 an hour after applying the fix
showed no leaks.
---
 src/transform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/transform.c b/src/transform.c
index 39c3bda..90ce824 100644
--- a/src/transform.c
+++ b/src/transform.c
@@ -581,6 +581,7 @@ static struct tree *file_info(struct augeas *aug, const char *fname) {
     result = tree_find(aug, path);
     ERR_BAIL(aug);
  error:
+    free(path);
     return result;
 }
 
-- 
1.6.6.1

_______________________________________________
augeas-devel mailing list
augeas-devel redhat com
https://www.redhat.com/mailman/listinfo/augeas-devel

--- End Message ---

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]