[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/1] virt-viewer : add support for window scaling



On Sat, Jun 12, 2010 at 11:07:34AM +1000, ronnie sahlberg wrote:
> Hi,
> 
> Please find attached a small patch to "virt-viewer".
> 
> It adds a feature to scale the window by a certain percentage, when
> not in FullScreen mode.
> Default is 100, i.e. no scaling.
> 
> But the scaling can be set to any factor between 10 and 200 from the
> command line by using the added --scaling argument.

This looks fine.

> There is also a new Zoom submenu, where scaling of 25%, 50%, 75% and
> 100% can be adjusted at runtime.

I think the menu would be more flexible if it worked like the firefox
menu for zooming eg

   View
   ----
   Zoom -> Zoom In (Ctrl + +)
           Zoom Out (Ctrl + -)
           ------------------
           Normal (Ctrl + 0)
           Best fit

The nice bit is that GTK has stock icons defined for the Zoom In,
Zoom Out, Normal and Best Fit that are standardized across apps.


> I find this useful since I often run many virtual machines and I can
> then dedicate a desktop to show a whole bunch of 25% thumbnails.
> 
> I hope others will find it useful too.

Thanks for the proposal.  Your code looks good - if you can change the
menu structure I'd be happy to merge it.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]