[virt-tools-list] guestfish question

[Eric Blake]

On 11/05/2010 09:19 AM, Richard W.M. Jones wrote:
> 
> Thanks.  I have take up all these suggestions.  Would you mind
> looking over the small patches attached?

Looks good, with one nit:

> - eval `guestfish --listen`
> + eval "$(guestfish --listen)"

Since the point of patch 1 was to be portable to Solaris /bin/sh, which
doesn't understand $(), then patch 2 needs to use:

eval "`guestfish --listen`"

everywhere.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20101105/70bda1c0/attachment.sig>