[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] add AM_MAINTAINER_MODE macro



On 10/15/2010 07:29 AM, Guido Günther wrote:
> Hi,
> On Wed, Sep 29, 2010 at 04:46:23PM +0200, Guido Günther wrote:
>> Hi,
>> Please add the AM_MAINTAINER_MODE macro to configure.ac for
>> virt-manager. This allows downstream distributions to disable this
>> feature so no autotools are required to build the package. The patch
>> doesn't change behaviour for upstream:
>>
>>     http://www.gnu.org/software/hello/manual/automake/maintainer_002dmode.html 
>>
>> Cheers,
>>  -- Guido
>>
>> # HG changeset patch
>> # Parent 6b82807019e67edb5c00eeef22bb0dce06d1de8c
>> Add AM_MAINTAINER_MODE to ease work for downstreams
>>
>> diff --git a/configure.ac b/configure.ac
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -3,6 +3,7 @@
>>  AC_CONFIG_SRCDIR(src/virt-manager.py.in)
>>  dnl Make automake keep quiet about wildcards & other GNUmake-isms
>>  AM_INIT_AUTOMAKE([-Wno-portability])
>> +AM_MAINTAINER_MODE([enable])
>>  
>>  ALL_LINGUAS="as bg bn_IN bs ca cs da de es fi fr gu hi hr hu is it ja kn ko ml mr ms nb nl or pa pl pt_BR pt ro ru sr latin sr sv ta te tr uk zh_CN zh_TW"
>>  IT_PROG_INTLTOOL([0.35.0], [no-xml])
> 
> Any chance this gets applied?

Ah, my bad, I thought this patch was against virt-viewer. From the
discussion it sounds like the change is fine, so I've pushed it now:

http://hg.fedorahosted.org/hg/virt-manager/rev/c9758a35af24

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]