[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[virt-tools-list] [VIRT-VIEWER PATCH] Remove VIR_CONNECT_RO flag from virConnectOpenAuth call



Hi,
this is the patch I did yesterday evening when struggling with the virt-viewer I just cloned from the mercurial tree. This is the patch to remove VIR_CONNECT_RO flag from virConnectOpenAuth() call since the virt-viewer was not working for me saying it can't connect to libvirt, i.e. returning the NULL pointer from the function mentioned.

I don't know what's wrong (but it most probably be in libvirt since the virConnectOpenAuth function returns a NULL pointer when the read-only flag is set) and why there was a read-only flag set nevertheless if this is intentional we should consider adding a flag to optionally disable passing the read-only flag there.

Michal

Signed-off-by: Michal Novotny <minovotn redhat com>

--
Michal Novotny<minovotn redhat com>, RHCE
Virtualization Team (xen userspace), Red Hat

diff -r eb3fb9f7894c src/viewer.c
--- a/src/viewer.c	Thu Sep 30 08:48:33 2010 +0000
+++ b/src/viewer.c	Thu Sep 30 12:02:09 2010 +0200
@@ -1241,7 +1241,7 @@
 	viewer->conn = virConnectOpenAuth(uri,
 					  //virConnectAuthPtrDefault,
 					  &auth_libvirt,
-					  VIR_CONNECT_RO);
+					  0);
 	if (!viewer->conn) {
 		viewer_simple_message_dialog(NULL, _("Unable to connect to libvirt with URI %s"),
 					     uri ? uri : _("[none]"));

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]