[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 2/2] console: avoid division by zero if desktop_resolution has height of 0



On 04/13/2011 07:59 AM, Marc-André Lureau wrote:
> ---
>  src/virtManager/console.py |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/src/virtManager/console.py b/src/virtManager/console.py
> index 0687b83..d4cf44f 100644
> --- a/src/virtManager/console.py
> +++ b/src/virtManager/console.py
> @@ -1068,8 +1068,6 @@ class vmmConsolePages(vmmGObjectUI):
>          align_ratio = float(req.width) / float(req.height)
>  
>          desktop_w, desktop_h = self.viewer.get_desktop_resolution()
> -        if desktop_h == 0:
> -            return
>          desktop_ratio = float(desktop_w) / float(desktop_h)
>  
>          if not is_scale:

Somethings funny here? You add this chunk in the previous patch then
remove it in the next one?

Also, when do we see a height of 0?

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]