[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [RFC PATCH 00/10] virt-manager: Prep for sharing code with TUI



On 04/25/2011 08:14 AM, Darryl L. Pierce wrote:
> On Mon, Apr 18, 2011 at 02:06:42PM -0400, Cole Robinson wrote:
>> The following series is a first steps towards sharing code between
>> virt-manager GUI and TUI. On it's own it doesn't do much, just handles
>> the tricky parts of using the GUI's 'model' code in the TUI.
>>
>> First 5 patches are minor TUI improvements to make it simpler to test
>> the code. The latter patches push the gtk/gobject deps up from connection.py
>> into a central place that can be toggled on/off at app startup.
> 
> ACK to the set.
> 

Thanks, I've pushed 1-9, 10 was just a broken hack to demonstrate the
direction this was heading.

Additionally I converted all the virtManager code to use
vmmGObject.signal_new like was done in patch 8 and 9.

The M in MVC is basically the following files:

connection.py
domain.py
interface.py
mediadev.py
netdev.py
network.py
nodedev.py
storagepool.py
storagevol.py

This code should currently be clean from all gtk or gobject imports,
with the exception of connection.py which has an 'import gtk' lingering.
It should be a minor amount of work to unwind this, which needs to be
done anyway since it touches the connect-to-uri logic that is probably
virt-manager specific at this point. But I'll leave that up to you :)

- Cole

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]