[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/2] virt install: Remove check for absolute path for fs target



On 12/21/2011 12:52 AM, Deepak C Shetty wrote:
> In case of qemu for default fs type (mount) target is not
> actually a directory, it is merely a arbitrary string tag
> that is exported to the guest as a hint for where to mount.
> 
> Signed-off-by: Deepak C Shetty <deepakcs linux vnet ibm com>
> ---
> 
>  virtinst/VirtualFilesystem.py |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/virtinst/VirtualFilesystem.py b/virtinst/VirtualFilesystem.py
> index 5732a9e..a74d009 100644
> --- a/virtinst/VirtualFilesystem.py
> +++ b/virtinst/VirtualFilesystem.py
> @@ -116,7 +116,17 @@ class VirtualFilesystem(VirtualDevice.VirtualDevice):
>      def _get_target(self):
>          return self._target
>      def _set_target(self, val):
> -        if not os.path.isabs(val):
> +        if self.conn:
> +            is_qemu = self.is_qemu()
> +

If self.conn is None, is_qemu will be referenced before assignment.

Thanks,
Cole

> +        # In case of qemu for default fs type (mount) target is not 
> +        # actually a directory, it is merely a arbitrary string tag
> +        # that is exported to the guest as a hint for where to mount
> +        if (is_qemu and
> +            (self.type == self.TYPE_DEFAULT or
> +             self.type == self.TYPE_MOUNT)):
> +             pass
> +        elif not os.path.isabs(val):
>              raise ValueError(_("Filesystem target '%s' must be an absolute "
>                                 "path") % val)
>          self._target = val
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list redhat com
> https://www.redhat.com/mailman/listinfo/virt-tools-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]