[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] Problems with virtinst NIC tests



On 02/11/2011 10:37 AM, Eric Blake wrote:
> On 02/11/2011 08:27 AM, Cole Robinson wrote:
>>> Once that's done I see another failure because change-nics-out.xml
>>> has XML elements in the wrong order:
>>>
> 
>>>      <interface type="bridge">
>>> +      <source bridge="newbr0"/>
>>>        <mac address="11:22:33:44:55:66"/>
>>>        <model type="virtio"/>
>>> -      <source bridge="newbr0"/>
>>>      </interface>
> 
>>
>> The xmlparse test is using virtinst to alter an XML definition in place, which
>> can cause XML elements to come and go. New elements are always added at the
>> end of the block, so it won't always generate the same ordering as libvirt uses.
> 
> Should the .rng file be using <interleave> to allow these elements in
> arbitrary order?
> 

Everything should probably be interleave in the rng, at least for XML input. I
can't think of a single case where any sort of strict ordering is required,
though ordering does have value for cases like boot device list and disk
device ordering.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]